Manchester | 25-ITP-Sep | Mahtem T. Mengstu | Sprint 2 | coursework/sprint-2 #805
Conversation
…, interpreted the error and wrote a new and corrected code.
…and modified the code
… has been writtent and implemented
…int 1 and rearranged it into a reusable function toPounds()
…d modified the code.
Mahtem
added
📅 Sprint 2
| suffix = "am"; | ||
| } | ||
|
|
||
| hours = hours % 12 || 12; // convert 0 to 12, 13 to 1 |
There was a problem hiding this comment.
Can you explain how the expression hours % 12 || 12 convert 0 to 12 and 13 to 1?
There was a problem hiding this comment.
Can you explain how the expression
hours % 12 || 12convert 0 to 12 and 13 to 1?
The expression converts 0 to 12, 13 to 1 and soon as it returns the remainder
for eg. taking 12/12 the remainder is 0
similarly if 13 is taken 13/12 , the remainder is 1, the operator || helps us to return the remainder after
a division operation.
There was a problem hiding this comment.
My previous question might not be very clear. This is what I would like to find out:
Suppose expr1 and expr2 are some JavaScript expressions.
Can you explain how the expression expr1 || expr2 is evaluated in JavaScript?
|
|
||
| // Modified Code: | ||
|
|
||
| function formatAs12HourClock(time) { |
There was a problem hiding this comment.
There is another function with the same name defined on lines 6-12. Do you still need that function?
There was a problem hiding this comment.
There is another function with the same name defined on lines 6-12. Do you still need that function?
Thank you, I do not need that function, I have commented it out.
There was a problem hiding this comment.
To keep our code clean (as a best practice), it is better to delete the code we no longer need. Should we ever need to recover the code, we can always find them in one of the commits we made.
cjyuan
added
Reviewed
…t the function return a number.
…ce(-2) and explained hours = hours % 12 || 12;
Mahtem
added
the
Needs Review
cjyuan
removed
the
Needs Review
2 participants
Learners, PR Template
Self checklist
Changelist
Completed course works of Sprint 2 from module structuring and testing data
Questions
Questions and blockers will be forwarded to slack.